Skip to content

Fix PathToUrl to correctly handle external URLs #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 23, 2025
Merged

Fix PathToUrl to correctly handle external URLs #1075

merged 4 commits into from
May 23, 2025

Conversation

claudiamurialdo
Copy link
Collaborator

@genexusbot
Copy link
Collaborator

Cherry pick to beta success

ggallotti
ggallotti previously approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@ggallotti ggallotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add some Linux paths to the test cases. 😀

@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests January 8, 2025 15:24 — with GitHub Actions Inactive
@genexusbot
Copy link
Collaborator

Cherry pick to beta success

ggallotti
ggallotti previously approved these changes Jan 10, 2025
View reviewed changes
@claudiamurialdo
PathToUrl generated an incorrect URL for local image paths when used …
eb0e05a 
…in command-line applications.

Add null checks for _HttpContext to prevent NullReferenceException in command-line applications.
@claudiamurialdo claudiamurialdo had a problem deploying to external-storage-tests May 17, 2025 13:33 — with GitHub Actions Failure
@claudiamurialdo claudiamurialdo temporarily deployed to kafka-integration-tests May 17, 2025 13:33 — with GitHub Actions Inactive
@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@claudiamurialdo claudiamurialdo temporarily deployed to kafka-integration-tests May 17, 2025 13:50 — with GitHub Actions Inactive
@claudiamurialdo claudiamurialdo had a problem deploying to external-storage-tests May 17, 2025 13:50 — with GitHub Actions Failure
@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@claudiamurialdo claudiamurialdo merged commit 2d2fa85 into master May 23, 2025
8 of 10 checks passed
@claudiamurialdo claudiamurialdo deleted the path-to-url branch May 23, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggallotti ggallotti ggallotti left review comments

Assignees
No one assigned
Labels
bot closed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@claudiamurialdo @genexusbot @ggallotti